-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid ID collisions between ED and ES modules in MessageLogger [12_4] #38742
Avoid ID collisions between ED and ES modules in MessageLogger [12_4] #38742
Conversation
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_12_4_X. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30b657/26251/summary.html Comparison SummarySummary:
|
backport of #38728 |
@cms-sw/core-l2 do you see any issue with signing this for 12_4_X? |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Separate IDs used by ED and ES modules when checking cache in MessageLogger.
back port of #38728
PR validation:
Code compiles.