Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid ID collisions between ED and ES modules in MessageLogger [12_4] #38742

Merged

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Separate IDs used by ED and ES modules when checking cache in MessageLogger.

back port of #38728

PR validation:

Code compiles.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 14, 2022

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_12_4_X.

It involves the following packages:

  • FWCore/MessageService (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30b657/26251/summary.html
COMMIT: 5d2898e
CMSSW: CMSSW_12_4_X_2022-07-14-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38742/26251/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676111
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3676081
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

backport of #38728

@perrotta
Copy link
Contributor

@cms-sw/core-l2 do you see any issue with signing this for 12_4_X?
I think it could be included in the next 12_4_3 that we intend to build shortky

@makortel
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 15, 2022

+1

@cmsbuild cmsbuild merged commit d3669f4 into cms-sw:CMSSW_12_4_X Jul 15, 2022
@Dr15Jones Dr15Jones deleted the fixMessageLoggerIDCollision_12_4 branch July 18, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants